Repository navigation
Hide discover section - #86726
Hide discover section#86726
Conversation
|
@codex review |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-04-02.15.28.42.movAndroid: mWeb Chrome2026-04-02.15.26.15.moviOS: HybridApp2026-04-02.15.28.42.moviOS: mWeb Safari2026-04-02.15.26.15.movMacOS: Chrome / Safari2026-03-31.14.01.14.mov |
|
I suppose we need to update the logic a bit 2026-03-31.14.01.14.mov |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
| } = useOnboardingTaskInformation(CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR); | ||
| const parentReportAction = useParentReportAction(viewTourTaskReport); | ||
| const [hasSeenTour = true] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {selector: hasSeenTourSelector}); | ||
| const [hasSeenTour] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {selector: hasSeenTourSelector}); |
There was a problem hiding this comment.
@ZhenjaHorbach this should fix that flash bug
There was a problem hiding this comment.
But no
It wouldn't work 😅
Since hasSeenTourSelector returns false in case when onyx onboarding is undefined
2026-04-01.14.10.38.mov
I suppose we need to remove the selector and use
if(onboarding?.selfTourViewed !== false){
return null;
}
There was a problem hiding this comment.
hmmm not great that selectors default to an incorrect value when not loaded, but I'll make this change here for now
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@grgia By default, we don't get selfTourViewed from BE As a result, the new condition won't work as expected It should look something like this Sorry for the unnecessary disturbance 😅 |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
LGTM! |
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
Yes, the help site needs updating. The Discover section in I've created a draft PR with the required changes: #87191 Changes made:
All changes follow the HELPSITE_NAMING_CONVENTIONS, HELP_AUTHORING_GUIDELINES, and TEMPLATE conventions. Please mark it as "Ready for review" when it looks good. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
Deploy Blocker #87195 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀
|
Reflects the change from PR #86726 where the Discover section on Home is now hidden once the user has watched the tour demo. Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
Explanation of Change
The Discover Section on the Home Page rendered unconditionally, even after the user had already watched the tour. Added an early return null in DiscoverSection when
hasSeenTouris true, hiding the section for users who have already viewed it. The component already read this value from Onyx, it just wasn't using it to control visibility.Fixed Issues
$ #86445
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Verify that no errors appear in the JS console
false/unset)
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari